Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12976 )
Change subject: tool: fixes for kudu local_replica dump rowset ...................................................................... tool: fixes for kudu local_replica dump rowset This patch makes several adjustments to 'kudu local_replica dump rowset': - The existing 'metadata_only' and 'nrows' controls were being ignored. - The existing 'rowset_index' control wasn't working properly. - I changed the "what to dump" contols to 'dump_all_columns' and 'dump_metadata'. When 'dump_all_columns' is false, the row keys are dumped in a format that's comparable and ASCII-compatible (currently hex). This functionality helped me dump a tablet's keys (grouped by rowset), which I then used for a series of MergeIterator experiments. Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f Reviewed-on: http://gerrit.cloudera.org:8080/12976 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_local_replica.cc 2 files changed, 163 insertions(+), 57 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/12976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib50ab4e7b2aa0fec60ce0718d16823945a05cb7f Gerrit-Change-Number: 12976 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]>
