Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 )
Change subject: [ksck] Make ksck tool more concurrent ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/13024/5/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/13024/5/src/kudu/tools/ksck.cc@176 PS5, Line 176: CHECK_OK(pool_->SubmitFunc([&]() { this can be a RETURN_NOT_OK because the function returns a Status. http://gerrit.cloudera.org:8080/#/c/13024/5/src/kudu/tools/ksck.cc@337 PS5, Line 337: CHECK(pool_.get()); You can remove this; it's guaranteed by the constructor. http://gerrit.cloudera.org:8080/#/c/13024/5/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/13024/5/src/kudu/tools/ksck_remote.cc@566 PS5, Line 566: CHECK(pool_.get()); Can be dropped; guaranteed by the constructor. -- To view, visit http://gerrit.cloudera.org:8080/13024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f3f0e3f5115a46dd3afc83dda75e7241618eea4 Gerrit-Change-Number: 13024 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Thu, 18 Apr 2019 18:23:57 +0000 Gerrit-HasComments: Yes
