Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 )
Change subject: [ksck] Make ksck tool more concurrent ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/13024/6/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/13024/6/src/kudu/tools/ksck.cc@340 PS6, Line 340: RETURN_NOT_OK(pool_->SubmitFunc([&]() { > Can be RETURN_NOT_OK. Done http://gerrit.cloudera.org:8080/#/c/13024/6/src/kudu/tools/ksck.cc@373 PS6, Line 373: std::lock_guard<simple_spinlock> lock(tablet_server_summaries_lock); > This needs to acquire tablet_server_summaries_lock as well, so that multipl Done http://gerrit.cloudera.org:8080/#/c/13024/6/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/13024/6/src/kudu/tools/ksck_remote.cc@534 PS6, Line 534: LOG(ERROR) << Substitute("unable to open table $0: $1", table_name, s.ToString()); > Why do you need to acquire this? I don't think table_name access needs to b Done -- To view, visit http://gerrit.cloudera.org:8080/13024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f3f0e3f5115a46dd3afc83dda75e7241618eea4 Gerrit-Change-Number: 13024 Gerrit-PatchSet: 7 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 19 Apr 2019 06:43:22 +0000 Gerrit-HasComments: Yes
