Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12852 )

Change subject: [maintenance] Add privilege maintenance thread pool for 
privilege tables and tablets
......................................................................


Patch Set 1:

> Patch Set 1:
>
> > 3. Like rocksDB, we keep two kind of thread pools, one for flush, and the 
> > other for compaction(and GC in Kudu).
>
> How does this work? Are priority multipliers only applied to the 
> compaction/GC pool?
>
> Separately, if the goal is to do some sort of resource management on tablets, 
> shouldn't we also consider prioritization at the point of ingest (i.e. during 
> a Write RPC)? By only considering the MM we're potentially putting ourselves 
> in difficult situations (e.g. a bunch of data can't be GC'ed because although 
> it was written successfully, the tablet is "low" priority so the MM has 
> deprioritized WAL GC for it).

Priority multipliers only applied to the compaction ops to improve performance.
Priority multipliers could not applied to GC ops and flush ops, so they can 
work like before.


--
To view, visit http://gerrit.cloudera.org:8080/12852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ea3b73505157678a8fb551656123b64e6bfb304
Gerrit-Change-Number: 12852
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 08 May 2019 02:33:02 +0000
Gerrit-HasComments: No

Reply via email to