Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 )
Change subject: [maintenance] Add privilege maintenance thread pool for privilege tables and tablets ...................................................................... Patch Set 1: > Patch Set 1: > > > Priority multipliers only applied to the compaction ops to improve > > performance. > > Priority multipliers could not applied to GC ops and flush ops, so they can > > work like before. > > Oh okay; so it's just about prioritizing/deprioritizing compactions? That > makes sense to me, and is a reasonable place to start. > Yes > Have you had a chance to consider Todd's last bit of feedback? I've copied it > below: > > > The last question I have is about the use of gflags for this purpose. It > > seems like this should probably be a table property settable via the API at > > runtime, rather than a gflag. For example, we could use the 'extra config' > > functionality provided by https://gerrit.cloudera.org/c/12468/ I think I have to wait this patch to be merged before adding a priority property into table. Before that, I could keep to use gflags, and we can controll server one by one by gflags. -- To view, visit http://gerrit.cloudera.org:8080/12852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ea3b73505157678a8fb551656123b64e6bfb304 Gerrit-Change-Number: 12852 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2019 06:10:22 +0000 Gerrit-HasComments: No
