Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13287 )
Change subject: KUDU-2711 pt 4. Java support for GetTableLocations optimizations ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13287/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: PS1: > Some lines are too long. Which ones? We don't have a hard and fast rule for Java, but the rule I use is that lines should be 100 chars or less, and most should be 80 or less. http://gerrit.cloudera.org:8080/#/c/13287/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2152 PS1, Line 2152: * Makes discovered tablet locations visible in the client's caches. > Update list of params. Done http://gerrit.cloudera.org:8080/#/c/13287/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2211 PS1, Line 2211: // TODO(wdberkeley): Change this so ReplicaPBs aren't used by the client at all anymore. > What's the remaining work to make this happen? Mostly changing LocatedTablet.Replica so instead of wrapping a ReplicaPB it's some kind of POD object with the same information. It's a decent amount of plumbing with no obvious payoff since we can't actually get rid of ReplicaPB anytime soon and it's a convenient POD object itself. -- To view, visit http://gerrit.cloudera.org:8080/13287 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af146fd1984ce683f056877129506cd2068e0e8 Gerrit-Change-Number: 13287 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2019 16:41:57 +0000 Gerrit-HasComments: Yes
