Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13287 )

Change subject: KUDU-2711 pt 4. Java support for GetTableLocations optimizations
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13287/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

PS1:
> Which ones? We don't have a hard and fast rule for Java, but the rule I use
L2209 for example. I was assuming that it's too long if it wraps in the gerrit 
UI.



--
To view, visit http://gerrit.cloudera.org:8080/13287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5af146fd1984ce683f056877129506cd2068e0e8
Gerrit-Change-Number: 13287
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Thu, 09 May 2019 18:55:19 +0000
Gerrit-HasComments: Yes

Reply via email to