Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13356 )
Change subject: [backup] Add a basic CLI tool ...................................................................... Patch Set 1: (2 comments) Just passing through... http://gerrit.cloudera.org:8080/#/c/13356/1/java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala File java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala: PS1: Copyright header. http://gerrit.cloudera.org:8080/#/c/13356/1/java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupCLI.scala@91 PS1, Line 91: println("OK") Can we drop this? The exit status can always be derived from $? after running the shell command. -- To view, visit http://gerrit.cloudera.org:8080/13356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a4d3b44c77a06fa1b5d2b09506ba5a6e1b52c1 Gerrit-Change-Number: 13356 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 17 May 2019 18:13:10 +0000 Gerrit-HasComments: Yes
