Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13356 )
Change subject: [backup] Add a basic CLI tool ...................................................................... Patch Set 4: > Looks good. Can you add a simple unit test to just verify that the > tool basically works? I'm OK with not meticulously validating > everything, but basically triggering a couple of backups and then > running the tool in tsv mode and parsing the output to show that > the tables we expected are shown in the output seems simple to do > and would warn us if the tool ever became totally broken for some > reason. Done -- To view, visit http://gerrit.cloudera.org:8080/13356 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a4d3b44c77a06fa1b5d2b09506ba5a6e1b52c1 Gerrit-Change-Number: 13356 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 08:53:43 +0000 Gerrit-HasComments: No
