Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12852 )
Change subject: [maintenance] Support priorities for tables in MM compaction ...................................................................... Patch Set 6: Code-Review+2 (2 comments) LGTM. Ideally I'd rather improve the maintenance manager so it accounts for the factors that make some tables high priority, e.g. by looking at how often tables are read or written. But this is fine for now. Can you file a JIRA with some details about what prompted this patch? What was the workload like on the high priority table? What was it like on the tables that were actually the target of MM ops? Some details might help plan future MM improvements. http://gerrit.cloudera.org:8080/#/c/12852/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12852/6//COMMIT_MSG@9 PS6, Line 9: add adds http://gerrit.cloudera.org:8080/#/c/12852/6//COMMIT_MSG@14 PS6, Line 14: allow allows -- To view, visit http://gerrit.cloudera.org:8080/12852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ea3b73505157678a8fb551656123b64e6bfb304 Gerrit-Change-Number: 12852 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 20 May 2019 17:22:37 +0000 Gerrit-HasComments: Yes
