Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12852 )

Change subject: [maintenance] Support priorities for tables in MM compaction
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12852/5/src/kudu/util/maintenance_manager-test.cc
File src/kudu/util/maintenance_manager-test.cc:

http://gerrit.cloudera.org:8080/#/c/12852/5/src/kudu/util/maintenance_manager-test.cc@345
PS5, Line 345:   manager_->RegisterOp(&op);
> Likewise, does this increase the chance of the test failing, if the two rem
Done


http://gerrit.cloudera.org:8080/#/c/12852/5/src/kudu/util/maintenance_manager.cc
File src/kudu/util/maintenance_manager.cc:

http://gerrit.cloudera.org:8080/#/c/12852/5/src/kudu/util/maintenance_manager.cc@342
PS5, Line 342:   
CHECK_OK(thread_pool_->SubmitFunc(boost::bind(&MaintenanceManager::LaunchOp, 
this, op)));
             :
> You can combine this.
Done



--
To view, visit http://gerrit.cloudera.org:8080/12852
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ea3b73505157678a8fb551656123b64e6bfb304
Gerrit-Change-Number: 12852
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Sat, 18 May 2019 05:56:23 +0000
Gerrit-HasComments: Yes

Reply via email to