Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@74 PS1, Line 74: // System env to track if the HMS plugin validation should be skipped. nit: maybe move this into the class header, that if the KUDU_SKIP_HMS_PLUGIN_VALIDATION is set (to 0? nonzero? anything?), the plugin will skip all validation. http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@263 PS1, Line 263: skipValidation.isEmpty() > nit: I'm not an expert in Java and its conventions, but what if somebody se Seems we do this at least once here: https://github.com/apache/kudu/blob/c550fe8f55ee0a4c6838d246e00e541ef4cff460/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java#L154 I agree it'd be more intuitive, though I don't feel particularly strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/13387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b Gerrit-Change-Number: 13387 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 May 2019 19:14:03 +0000 Gerrit-HasComments: Yes
