Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13387 )
Change subject: hms: allow skip validation in Hive Metastore Kudu plugin ...................................................................... Patch Set 2: Verified+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@74 PS1, Line 74: static final String KUDU_TABLE_ID_KEY = "kudu.table_id"; > nit: maybe move this into the class header, that if the KUDU_SKIP_HMS_PLUGI Done http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@261 PS1, Line 261: } > nit: is it possible to make this method static? Done http://gerrit.cloudera.org:8080/#/c/13387/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@263 PS1, Line 263: masterAddresses.isEmpty( > Seems we do this at least once here: To align with the existing handling. I added the logic to not skip validation if it is set to 0. -- To view, visit http://gerrit.cloudera.org:8080/13387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fe686ce4b1d1fdb2dcdf0fcf1c177076465c01b Gerrit-Change-Number: 13387 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 May 2019 01:13:58 +0000 Gerrit-HasComments: Yes
