Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13397 )
Change subject: [java] Fix TestHybridTime ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/13397/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java: http://gerrit.cloudera.org:8080/#/c/13397/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@108 PS1, Line 108: assertEquals(clockValues[1], 0); > Hmm, why is this guaranteed? Isn't it that the logical value of a hybrid timestamp that hasn't been logically "bumped" should be 0? http://gerrit.cloudera.org:8080/#/c/13397/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@109 PS1, Line 109: long toUpdateTs nit: toUpdateTs made me think that this was going to be updated at some point. Would a name like final long futureTs or somesuch be more apt? -- To view, visit http://gerrit.cloudera.org:8080/13397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98a5bccf2fb366004659f3e6169b5f57f7ced485 Gerrit-Change-Number: 13397 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 21:15:03 +0000 Gerrit-HasComments: Yes
