Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13397 )
Change subject: [java] Fix TestHybridTime ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13397/1//COMMIT_MSG Commit Message: PS1: > Also did you loop this and see the drop in flakiness? Probably worth noting Added to commit message. http://gerrit.cloudera.org:8080/#/c/13397/1//COMMIT_MSG@10 PS1, Line 10: However, sometimes : there are jumps in the logical values of the logical clock > Do we know why? Would be good to doc. No, I'm not sure why. Of course it can happen if there are concurrent operations but I'm not sure what they are in this case. http://gerrit.cloudera.org:8080/#/c/13397/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java: http://gerrit.cloudera.org:8080/#/c/13397/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@108 PS1, Line 108: assertEquals(clockValues[1], 0); > Isn't it that the logical value of a hybrid timestamp that hasn't been logi Yeah. I'm not 100% sure it's guaranteed, but if we see flakiness here that'll tell us, and it will inspire me to look into what's going on server side with the logical clock. http://gerrit.cloudera.org:8080/#/c/13397/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@109 PS1, Line 109: long toUpdateTs > nit: toUpdateTs made me think that this was going to be updated at some poi Done -- To view, visit http://gerrit.cloudera.org:8080/13397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98a5bccf2fb366004659f3e6169b5f57f7ced485 Gerrit-Change-Number: 13397 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 18:33:40 +0000 Gerrit-HasComments: Yes
