Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13410 )
Change subject: hms: followup to 6a8d1d2 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/13410/1/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13410/1/src/kudu/tools/tool_action_hms.cc@307 PS1, Line 307: // If this is a legacy table or external table, we don't expect a table Can you adjust this to match the logic below more closely. Something like: > If this is a managed Kudu table, lookup the table by ID. Otherwise look it up > by table name. -- To view, visit http://gerrit.cloudera.org:8080/13410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d624258e1d177363fceba6b40d6aee77b142b54 Gerrit-Change-Number: 13410 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 May 2019 13:47:18 +0000 Gerrit-HasComments: Yes
