Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13410 )
Change subject: hms: followup to 6a8d1d2 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13410/2/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/13410/2/src/kudu/integration-tests/master_hms-itest.cc@409 PS2, Line 409: ASSERT_OK(hms_client_->AlterTable("default", "ext2", new_ext)); Maybe, add hms_client_->GetTable("default", "ext2", ...) and hms_client_->GetTable("default", "ext3", ...), making sure the former fails and the latter succeeds? Not sure whether that's already guaranteed to be like this after AlterTable() completed successfully. Also, do we have a test to make sure the external references work as expected once we rename the underlying managed table? -- To view, visit http://gerrit.cloudera.org:8080/13410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d624258e1d177363fceba6b40d6aee77b142b54 Gerrit-Change-Number: 13410 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 May 2019 17:56:57 +0000 Gerrit-HasComments: Yes
