Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto ...................................................................... Patch Set 1: (6 comments) Thanks for this contribution! http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13407/1//COMMIT_MSG@8 PS1, Line 8: > Do you mind adding more detailed description on what this manifesto allows Agee that it would be useful to provide a detailed description or example of how this should be used. Instead of adding it to the commit message, adding a README.adoc (similar to the one in the docker directory) would be preferred. http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml File kubernetes/kudu-statefulset.yaml: http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@31 PS1, Line 31: type: LoadBalancer Is this making the master web UI load balanced? Users need to be able to hit each ui instance as needed. http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@35 PS1, Line 35: apiVersion: apps/v1beta1 Can we use apps/v1? http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@69 PS1, Line 69: value: "kudu-master-0.kudu-masters.default.svc.cluster.local,kudu-master-1.kudu-masters.default.svc.cluster.local,kudu-master-2.kudu-masters.default.svc.cluster.local" Is there a way for this to be generated? For example if someone wanted 1 or 5 masters and didn't update this. http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@122 PS1, Line 122: apiVersion: apps/v1beta1 Can we use apps/v1? http://gerrit.cloudera.org:8080/#/c/13407/1/kubernetes/kudu-statefulset.yaml@156 PS1, Line 156: value: "kudu-master-0.kudu-masters.default.svc.cluster.local,kudu-master-1.kudu-masters.default.svc.cluster.local,kudu-master-2.kudu-masters.default.svc.cluster.local" Same question as above about this being generated. -- To view, visit http://gerrit.cloudera.org:8080/13407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d Gerrit-Change-Number: 13407 Gerrit-PatchSet: 1 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 23 May 2019 14:07:31 +0000 Gerrit-HasComments: Yes
