Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13407 )
Change subject: KUDU-2398: Kudu kubernetes statefulset manifesto ...................................................................... Patch Set 3: (3 comments) Just a few small requests and this looks good to be committed as a starting point. I will follow up with a documentation patch that adds a readme. http://gerrit.cloudera.org:8080/#/c/13407/3/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/13407/3/docker/kudu-entrypoint.sh@56 PS3, Line 56: # TODO: Remove use_hybrid_clock=false when ntpd is setup. Just as an FYI, this TODO is important for production environments. I will open a few docker related jiras to track this stuff. http://gerrit.cloudera.org:8080/#/c/13407/3/docker/kudu-entrypoint.sh@86 PS3, Line 86: function get_k8s_kudu_masters() { I think I prefer hard coding in the manifest as opposed to putting K8s stuff in the entrypoint. Thanks for trying to solve my request though. Mind reverting? http://gerrit.cloudera.org:8080/#/c/13407/3/kubernetes/kudu-statefulset.yaml File kubernetes/kudu-statefulset.yaml: http://gerrit.cloudera.org:8080/#/c/13407/3/kubernetes/kudu-statefulset.yaml@18 PS3, Line 18: # This docker file defines a multistage build that supports creating I think this docker line is a copy paste error. -- To view, visit http://gerrit.cloudera.org:8080/13407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f87a70b3c6ac87bc531306855c80011dce3a61d Gerrit-Change-Number: 13407 Gerrit-PatchSet: 3 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 14:01:31 +0000 Gerrit-HasComments: Yes
