Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13410 )
Change subject: hms: followup to 6a8d1d2 ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13410/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13410/2/src/kudu/tools/tool_action_hms.cc@328 PS2, Line 328: managed_hms_tables_by_id[(*kudu_table)->id()].emplace_back( > nit: it's highly unlikely that another type of Kudu table appears in HMS, I don't think we should DCHECK because that's a property of the HMS and not in Kudu; also ISTR there being other types in Hive (e.g. managed_views, indexed_tables here https://hive.apache.org/javadocs/r2.1.1/api/org/apache/hadoop/hive/metastore/TableType.html), though we don't expect them in Kudu. I explicitly handled managed here instead. -- To view, visit http://gerrit.cloudera.org:8080/13410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d624258e1d177363fceba6b40d6aee77b142b54 Gerrit-Change-Number: 13410 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 May 2019 20:36:58 +0000 Gerrit-HasComments: Yes
