Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13424 )
Change subject: hms plugin: don't expect table type ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13424/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13424/1//COMMIT_MSG@10 PS1, Line 10: This It's great that you fixed that. I think the stack below is attributed to the problem that came out of the fact that 'parameters' was null. Maybe, fix that as well while you are here? http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@107 PS1, Line 107: checkNoKuduProperties(table) By my understanding, the NPE happened because table parameters was null (the source code of the version that gave NPE was different from upstream version). http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@229 PS1, Line 229: table.getParameters() What if table.getParameters() returns null? From the traceback it seems that was the case. -- To view, visit http://gerrit.cloudera.org:8080/13424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If76533a94f6ef2ae135af4bd441fc2652a6a5dda Gerrit-Change-Number: 13424 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 May 2019 18:34:12 +0000 Gerrit-HasComments: Yes
