Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13424 )
Change subject: hms plugin: don't expect table type ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13424/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13424/1//COMMIT_MSG@10 PS1, Line 10: This > Andrew mentioned that the actual code might be even something else, but any Ack http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@107 PS1, Line 107: checkNoKuduProperties(table) > By my understanding, the NPE happened because table parameters was null (th We chatted about this on Slack. The failure indeed came from checking table type, but as Alexey points out, it looks like the `parameters` field can be null as well. I'll put up a follow-up to handle that. I'll merge this though since it's valuable on its own I think, if you don't mind. http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@229 PS1, Line 229: table.getParameters() > What if table.getParameters() returns null? From the traceback it seems th Ack -- To view, visit http://gerrit.cloudera.org:8080/13424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If76533a94f6ef2ae135af4bd441fc2652a6a5dda Gerrit-Change-Number: 13424 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 25 May 2019 06:13:07 +0000 Gerrit-HasComments: Yes
