Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13435 )
Change subject: [KUDU-2825]add a column named role in 'kudu master list' add a column name role in 'kudu master list' to show the role of each master?roles include master,follower,learner, nonparticipant and unknowrole ...................................................................... Patch Set 1: (4 comments) Please add a unit test for this. Best location is probably kudu-tool-test.cc (you could modify TestMasterList). http://gerrit.cloudera.org:8080/#/c/13435/1//COMMIT_MSG Commit Message: PS1: Please reformat this a bit: 1. Summary should be "KDUU-2825: add a column named role in 'kudu master list' 2. Summary should only be one line; the rest should be in the description. 3. Replace tabs with spaces. http://gerrit.cloudera.org:8080/#/c/13435/1//COMMIT_MSG@10 PS1, Line 10: unknowrole unknown role. http://gerrit.cloudera.org:8080/#/c/13435/1/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/13435/1/src/kudu/tools/tool_action_master.cc@169 PS1, Line 169: } else if (boost::iequals(column, "role")) { Nit: we use two character spacing, not four. See the Google C++ style guide (which Kudu follows), specifically this section: https://google.github.io/styleguide/cppguide.html#Spaces_vs._Tabs http://gerrit.cloudera.org:8080/#/c/13435/1/src/kudu/tools/tool_action_master.cc@193 PS1, Line 193: }else { Nit: } else { -- To view, visit http://gerrit.cloudera.org:8080/13435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29da5024ec59d3fb1d576247b2f0f7af0e7968dc Gerrit-Change-Number: 13435 Gerrit-PatchSet: 1 Gerrit-Owner: GuangchaoDeng <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Sun, 26 May 2019 18:39:25 +0000 Gerrit-HasComments: Yes
