Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13435 )
Change subject: [KUDU-2825]add a column named role in 'kudu master list' ...................................................................... Patch Set 2: (12 comments) some nits http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@7 PS2, Line 7: [KUDU-2825]add a column named role in 'kudu master list' nit: add a space after the closing bracket http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@9 PS2, Line 9: add a column name role "Added a column named 'role' ..." http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@10 PS2, Line 10: master leader http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@10 PS2, Line 10: ， Use regular period symbol, i.e. dot '.' (ASCII code 46) http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@10 PS2, Line 10: , Here and elsewhere in this sentence: add space after comma. http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@10 PS2, Line 10: roles capitilize 'r': Roles http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@11 PS2, Line 11: unknow unknown http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@11 PS2, Line 11: 。 User regular period symbol, i.e. dot '.' (ASCII code 46) http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@11 PS2, Line 11: ’role‘ For consistency, use the same quote symbol (ASCII code 39), i.e. 'role' http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@11 PS2, Line 11: listed in the : default columns Maybe, the following is a bit clearer: By default, the tool's output has the 'role' column. http://gerrit.cloudera.org:8080/#/c/13435/2//COMMIT_MSG@13 PS2, Line 13: format: : kudu master list <master_addresses> [-columns=<columns>] : [-format=<format>] [-timeout_ms=<ms>] : columns (optional) : Comma-separated list of master info fields to include in : output.Possible values: uuid,rpc-addresses, http-addresses, : version,role and seqno. I think this is not necessary to add into the description. The tool generates this information if run with '--help'. http://gerrit.cloudera.org:8080/#/c/13435/2/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/13435/2/src/kudu/tools/tool_action_master.cc@384 PS2, Line 384: "rpc-addresses, http-addresses, version, seqno " add comma (i.e. ',') after 'seqno' -- To view, visit http://gerrit.cloudera.org:8080/13435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29da5024ec59d3fb1d576247b2f0f7af0e7968dc Gerrit-Change-Number: 13435 Gerrit-PatchSet: 2 Gerrit-Owner: GuangchaoDeng <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2019 21:24:00 +0000 Gerrit-HasComments: Yes
