Hello Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13440

to review the following change.


Change subject: thirdparty: fix memkind build on el6 machines
......................................................................

thirdparty: fix memkind build on el6 machines

- The configure.ac shipped with the bundled jemalloc generates a broken
  configure script when invoked with autoconf 2.63 (i.e. the version of
  autoconf found on el6. Here's a patch that works around the issue and
  allows the build to proceed.
- The configure.ac in memkind requires autoconf 2.64. With a little
  finagling, we can drop that dependency to 2.63.
- The memkind build assumes that clock_gettime (needed by jemalloc) is found
  in glibc, but that's only true for new versions of glibc. In old versions,
  it's actually in librt. [1]

1. https://github.com/memkind/memkind/issues/48

Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/memkind-fix-build-with-old-autoconf.patch
A thirdparty/patches/memkind-fix-build-with-old-glibc.patch
A thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch
4 files changed, 97 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13440/1
--
To view, visit http://gerrit.cloudera.org:8080/13440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118
Gerrit-Change-Number: 13440
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>

Reply via email to