Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13440 )
Change subject: thirdparty: fix memkind build on el6 machines ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG@11 PS1, Line 11: el6) > close parens Done http://gerrit.cloudera.org:8080/#/c/13440/1//COMMIT_MSG@11 PS1, Line 11: autoconf found on el6). Here's a patch that works around the issue and > nit: add closing parenthesis ')' Done http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch File thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch: http://gerrit.cloudera.org:8080/#/c/13440/1/thirdparty/patches/memkind-fix-jemalloc-build-with-old-autoconf.patch@26 PS1, Line 26: + AC_CHECK_HEADERS([dlfcn.h], , [have_dlsym="0"]) > nit: add [] to follow the style in other AC macros? Some of the other instances of this pattern in jemalloc's configure.ac do the same thing, so I'll leave it as-is. -- To view, visit http://gerrit.cloudera.org:8080/13440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02f3acebde7e3ea5400fe342c9c62736b8b43118 Gerrit-Change-Number: 13440 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2019 22:10:19 +0000 Gerrit-HasComments: Yes
