Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet metrics ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426/1/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: http://gerrit.cloudera.org:8080/#/c/13426/1/src/kudu/tserver/heartbeater.cc@77 PS1, Line 77: : DEFINE_int32(heartbeat_metrics_interval_ms, 5000, : "Interval at which the TS metrics to the master."); : TAG_FLAG(heartbeat_metrics_interval_ms, advanced); > Hmm, dirtying on each write would be expensive too. Maybe a two-period appr I think I agree with the premise of this approach. Spun slightly differently, period #1 could roughly indicate how frequently metrics are computed, whereas period #2 could indicate how frequently the reports (including metrics as well as everything else) would be sent to the master. It seems like it might be worthwhile to loosely couple (but still decouple) metrics from reporting, if we want to use this for more extensive "metrics" like histograms or somesuch. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 27 May 2019 22:59:41 +0000 Gerrit-HasComments: Yes
