helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet metrics ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13426/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/13426/1/src/kudu/tserver/ts_tablet_manager.cc@1276 PS1, Line 1276: CHECK_OK(replica->tablet()->CountRows(&count_rows)); > One idea might be to store a "rows as of last flush" in the tablet metadata Thank you, Andrew. You inspired me. I am trying to record the valid row counts in RowSet level. So, please hold on, let me try that patch first. ^_^ http://gerrit.cloudera.org:8080/#/c/13426/1/src/kudu/tserver/ts_tablet_manager.cc@1276 PS1, Line 1276: CountRows > Won't CountRows() initialize the cfile reader? And isn't that initializatio Ah, sorry for the mistake! I forgot that the deleted block is still there which is referenced by fs::ReadableBlock in CFileReader. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 12:04:04 +0000 Gerrit-HasComments: Yes
