Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13411 )
Change subject: hms: have tools ignore other clusters ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/kudu-tool-test.cc@3837 PS4, Line 3837: // The check tool will ignore the HMS metadata from the other cluster, and : // view the Kudu table as orphaned. What happens if the table id of the table entry from the other cluster matches with the Kudu table? Do you think we should handle that? http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13411/4/src/kudu/tools/tool_action_hms.cc@322 PS4, Line 322: if (FLAGS_ignore_other_clusters) { nit: Can you add a short description here of how master addrs are compared? -- To view, visit http://gerrit.cloudera.org:8080/13411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4e2ad5835fd7fedd1e963d234b153c1df5f8766 Gerrit-Change-Number: 13411 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 19:27:36 +0000 Gerrit-HasComments: Yes
