Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13411 )
Change subject: hms: have tools ignore other clusters ...................................................................... hms: have tools ignore other clusters Currently, the HMS tooling will check and fix the master addresses field of HMS entries based on strict string comparison, assuming that the HMS entry found for a Kudu table _should_ belong to the Kudu cluster being operated on. However, it is possible for there to exist metadata for multiple Kudu clusters in a single Hive Metastore instance. As such, tooling to check and fix a Kudu cluster's HMS integration shouldn't necessarily affect another's. This patch addresses this by imbuing the HMS tooling with the following behavior: - If any master address in a given HMS entry coincides with the expected Kudu masters, fix them (as was the behavior before); this is common if adding new masters, or replacing dead masters. - If none of the master addresses in the HMS entry coincide with those expected, the HMS entry may belong to another Kudu cluster. By default, the tools will ignore such HMS entries. The user can specify --noignore-other-clusters to have the tools check/fix such master addresses. Change-Id: Ib4e2ad5835fd7fedd1e963d234b153c1df5f8766 Reviewed-on: http://gerrit.cloudera.org:8080/13411 Tested-by: Kudu Jenkins Reviewed-by: Hao Hao <[email protected]> --- M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action_hms.cc 2 files changed, 143 insertions(+), 5 deletions(-) Approvals: Kudu Jenkins: Verified Hao Hao: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib4e2ad5835fd7fedd1e963d234b153c1df5f8766 Gerrit-Change-Number: 13411 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]>
