Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13415 )

Change subject: [backup] KUDU-2787 Allow single table failures for backup and 
restore
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13415/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13415/4//COMMIT_MSG@7
PS4, Line 7: [backup] KUDU-2787 Allow single table failures for backup and 
restore
s/and restore//


http://gerrit.cloudera.org:8080/#/c/13415/4/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File 
java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:

http://gerrit.cloudera.org:8080/#/c/13415/4/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@596
PS4, Line 596: doBackup
nit: Would you mind renaming this function to runBackup() to avoid confusion, 
since the helper in KuduBackup.scala is also named doBackup()?



--
To view, visit http://gerrit.cloudera.org:8080/13415
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f3731f8df04791727c44af9ade9989f2cc6ef95
Gerrit-Change-Number: 13415
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Comment-Date: Tue, 28 May 2019 22:53:52 +0000
Gerrit-HasComments: Yes

Reply via email to