Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13416 )
Change subject: [backup] KUDU-2787 Allow single table failures for backup and restore ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13416/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13416/2//COMMIT_MSG@7 PS2, Line 7: [backup] KUDU-2787 Allow single table failures for backup and restore s/backup and //; consider noting as part 2 of KUDU-2787 http://gerrit.cloudera.org:8080/#/c/13416/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala: http://gerrit.cloudera.org:8080/#/c/13416/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@164 PS2, Line 164: TODO: mind filing a jira for this? http://gerrit.cloudera.org:8080/#/c/13416/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@166 PS2, Line 166: We ought to try to clean up the mess when a failure happens. Are you thinking we should drop the table if we couldn't successfully restore it? http://gerrit.cloudera.org:8080/#/c/13416/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/13416/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@659 PS2, Line 659: doRestore nit: can we rename this to runRestore() to avoid confusion with the method of the same name in KuduRestore.scala? -- To view, visit http://gerrit.cloudera.org:8080/13416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dcc0be78e637b47f35e494dce4a6df274c8d559 Gerrit-Change-Number: 13416 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2019 23:09:49 +0000 Gerrit-HasComments: Yes
