Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13354 )
Change subject: [tool] Add cluster name resolver for CLI tools ...................................................................... Patch Set 5: (2 comments) > Patch Set 5: > > (3 comments) > > BTW, now that this is wrapping up we should further document the layout and > semantics of the YAML-based client config file. Would you like to do that in > a follow-up patch? I will do that http://gerrit.cloudera.org:8080/#/c/13354/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13354/4/src/kudu/tools/kudu-tool-test.cc@4644 PS4, Line 4644: ASSERT_TRUE(s.IsRuntimeError()); > Yeah but that's unique to your environment, right? Why should it be checked unsetenv returns success even if the environment variable doesn't exist, like in the Jenkins this test succeed. https://linux.die.net/man/3/unsetenv However, in the environment which has this environment variable, this test will fail if not unsetenv, because this test is for the case that the environment variable is not set. And I think after this patch has been merged, developers may add this ${KUDU_CONFIG} to their own developing environment, then this test will fail if not unsetenv. http://gerrit.cloudera.org:8080/#/c/13354/5/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13354/5/src/kudu/tools/kudu-tool-test.cc@619 PS5, Line 619: Corrput > Corrupt Done -- To view, visit http://gerrit.cloudera.org:8080/13354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fc235906adbf25fcc2059fa8443e3013830ec01 Gerrit-Change-Number: 13354 Gerrit-PatchSet: 5 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 02:03:22 +0000 Gerrit-HasComments: Yes
