Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13354 )
Change subject: [tool] Add cluster name resolver for CLI tools ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13354/1/src/kudu/tools/tool_action_common.cc File src/kudu/tools/tool_action_common.cc: http://gerrit.cloudera.org:8080/#/c/13354/1/src/kudu/tools/tool_action_common.cc@503 PS1, Line 503: // master_addresses: ip1:port1,ip2:port2,ip3:port3 > Done What do you think about using '@' or some other character that we know is invalid as a hostname to designate a cluster name? eg kudu table list @mycluster ('@' seems like a decent choice because it's not a special shell character whereas the rest of !#$%^&*() all seem to have some special significance in shells and would need escaping) -- To view, visit http://gerrit.cloudera.org:8080/13354 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fc235906adbf25fcc2059fa8443e3013830ec01 Gerrit-Change-Number: 13354 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2019 17:14:09 +0000 Gerrit-HasComments: Yes
