Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13448 )
Change subject: Apply gcc 9x patch to lss dependency ...................................................................... Patch Set 1: (3 comments) I took a look at our codebase and found a few other copies of LSS. Here's the summary: 1. The google-breakpad project expresses LSS as a third party dependency, and then Kudu expresses google-breakpad as its own third party dependency. That's what you're addressing in this change, and the approach makes sense as upstream google-breakpad has not yet revved its LSS dependency to pick up the fix (so upgrading our google-breakpad won't help). 2. Kudu itself has an old copy of LSS in src/kudu/gutil. Could you make sure it is patched as well? 3. Kudu's gperftools dependency has an embedded LSS. This was fixed in an upstream gperftools commit[1], but that has yet to make it into a gperftools release, so upgrading to gperftools 2.7 won't help us. I recommend we backport that commit into our gperftools patch list. 1. https://github.com/gperftools/gperftools/commit/9e5b1628737c67b4587f937164572774592978c4 http://gerrit.cloudera.org:8080/#/c/13448/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13448/1//COMMIT_MSG@7 PS1, Line 7: Apply gcc 9x patch to lss dependency > nit: can you put the bug number in this line of the commit message? eg "KUD Once you do that, you can remove the "KUDU-2829" line from L18. http://gerrit.cloudera.org:8080/#/c/13448/1//COMMIT_MSG@11 PS1, Line 11: poping popping http://gerrit.cloudera.org:8080/#/c/13448/1//COMMIT_MSG@12 PS1, Line 12: now gcc is yelling loudly and refusing to : compile when this occurs. Reading through https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52813, looks like they downgraded the error to a -Wdeprecated warning. Do you know whether that also landed in gcc9? We should still follow through with this commit; just wondering exactly what the severity is. -- To view, visit http://gerrit.cloudera.org:8080/13448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d1381454d570716692f850d30b53b01b1a94358 Gerrit-Change-Number: 13448 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 29 May 2019 17:53:52 +0000 Gerrit-HasComments: Yes
