Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13448 )
Change subject: KUDU-2829: Apply gcc 9x patch to lss dependency ...................................................................... Patch Set 2: (1 comment) > I believe I still need to updated breakpad patch to include the chrome team's > commit message. Agreed. http://gerrit.cloudera.org:8080/#/c/13448/2/src/kudu/gutil/linux_syscall_support.h File src/kudu/gutil/linux_syscall_support.h: http://gerrit.cloudera.org:8080/#/c/13448/2/src/kudu/gutil/linux_syscall_support.h@1661 PS2, Line 1661: : "esp", "memory"); \ My ASM intrinsics knowledge is not so good, but doesn't this change mean we're telling the compiler that we _will_ clobber esp? Isn't that the opposite of what we want? -- To view, visit http://gerrit.cloudera.org:8080/13448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d1381454d570716692f850d30b53b01b1a94358 Gerrit-Change-Number: 13448 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Reynolds <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Scott Reynolds <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sun, 02 Jun 2019 21:29:56 +0000 Gerrit-HasComments: Yes
