Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13471 )
Change subject: metrics-test: fix wrong metric name and improve metric filtering test ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/13471/1//COMMIT_MSG Commit Message: PS1: The reversal of arguments in ASSERT_STR_CONTAINS within metrics-test makes sense, but is this fixing something else too? Am I missing something? http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc@204 PS1, Line 204: ASSERT_EQ("test_counter", metric_name); Does WriteAsJson guarantee some deterministic order to the output? Otherwise how do we know that metrics[1] is the counter and not the gauge? http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc@219 PS1, Line 219: opts.entity_metrics.emplace_back("test_count"); Likewise, how will this match given the substring? http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc@238 PS1, Line 238: opts.entity_metrics.emplace_back("teST_coUNteR"); Given the underscore, how can this match as a case-insensitive substring of "My Test Counter"? -- To view, visit http://gerrit.cloudera.org:8080/13471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec50aa2364d5d5f98a89d4aa7a3b213a39afd569 Gerrit-Change-Number: 13471 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 30 May 2019 23:48:08 +0000 Gerrit-HasComments: Yes
