Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13471 )
Change subject: metrics-test: fix wrong metric name and improve metric filtering test ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc@219 PS1, Line 219: const rapidjson::Value* attributes; > The metric name of test_counter is wrong, it is "test_counter" instead of " Ack http://gerrit.cloudera.org:8080/#/c/13471/1/src/kudu/util/metrics-test.cc@238 PS1, Line 238: out.str(""); > It should match "test_counter". Ah, I see what you mean: we were trying to match the metric _label_, but matching happens on _names_. http://gerrit.cloudera.org:8080/#/c/13471/2/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/13471/2/src/kudu/util/metrics-test.cc@204 PS2, Line 204: std:: Add a 'using' for this. -- To view, visit http://gerrit.cloudera.org:8080/13471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec50aa2364d5d5f98a89d4aa7a3b213a39afd569 Gerrit-Change-Number: 13471 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 31 May 2019 20:10:54 +0000 Gerrit-HasComments: Yes
