Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 )
Change subject: KUDU-2514 Part 1: Support extra config for table. ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/common/wire_protocol.h File src/kudu/common/wire_protocol.h: http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/common/wire_protocol.h@154 PS16, Line 154: Status ExtraConfigPBToPBMap(const TableExtraConfigPB& pb, > The implementation doesn't share the same semantics as > ExtraConfigPBToMap: this method is "additive" (i.e. it doesn't blow > away 'configs'; it just replaces specific keys in it) while the > other method is not. > > That's why I recommended doing the merging directly in > CatalogManager::AlterTable rather than in one of these helpers. The > helpers should have simple, clear, and consistent semantics. More > complicated stuff should be handled by higher levels of the stack. Understand, I have modified ExtraConfigPBFromPBMap and ExtraConfigPBToPBMap to get them to meet the requirements. http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/common/wire_protocol.cc@661 PS16, Line 661: *configs = std::move(result); > Nit: Replace with: Done http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/common/wire_protocol.cc@679 PS16, Line 679: > Nit: "property" (since this is printing just one of them). Done http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/tablet/tablet_metadata-test.cc File src/kudu/tablet/tablet_metadata-test.cc: http://gerrit.cloudera.org:8080/#/c/12468/16/src/kudu/tablet/tablet_metadata-test.cc@96 PS16, Line 96: NO_FATALS(AlterSchema(*harness_->tablet()->schema(), boost::make_optional(extra_config))); > Should wrap this in NO_FATALS() because it has ASSERTs in it. Otherwise fai Done -- To view, visit http://gerrit.cloudera.org:8080/12468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0514507dca95602a97e954d1db464b907e073aae Gerrit-Change-Number: 12468 Gerrit-PatchSet: 18 Gerrit-Owner: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Comment-Date: Wed, 05 Jun 2019 08:58:17 +0000 Gerrit-HasComments: Yes
