Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12468 )
Change subject: KUDU-2514 Part 1: Support extra config for table. ...................................................................... Patch Set 19: (4 comments) For the most part looks good. Mostly nits. http://gerrit.cloudera.org:8080/#/c/12468/19/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: http://gerrit.cloudera.org:8080/#/c/12468/19/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@32 PS19, Line 32: import java.util.HashMap; nit: could you stick this before java.util.List so it's alphabetical? http://gerrit.cloudera.org:8080/#/c/12468/19/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/12468/19/src/kudu/common/wire_protocol.cc@656 PS19, Line 656: kudu. Why "table" and why "kudu"? The config maps are *Table*ExtraConfigPB. Do we expect these configs to ever _not_ be table configs or Kudu configs? Since these will be stored on disk, even though it's a small amount of space, could we do without the "kudu.table"? Or does it provide value via uniqueness of keys in some way? http://gerrit.cloudera.org:8080/#/c/12468/19/src/kudu/common/wire_protocol.cc@668 PS19, Line 668: config.first nit: It would be more straightforward if you pulled out config.first and config.second into their own variables, e.g. const string& config_name = config.first; const string& config_value = config.second; http://gerrit.cloudera.org:8080/#/c/12468/19/src/kudu/common/wire_protocol.cc@672 PS19, Line 672: history_max_age_sec nit: Should this be "kudu.table.history_max_age_sec"? Maybe use Substitute() and pass in config_name too (if you decide to take my suggestion). -- To view, visit http://gerrit.cloudera.org:8080/12468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0514507dca95602a97e954d1db464b907e073aae Gerrit-Change-Number: 12468 Gerrit-PatchSet: 19 Gerrit-Owner: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Comment-Date: Fri, 07 Jun 2019 06:19:11 +0000 Gerrit-HasComments: Yes
