Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 )
Change subject: [java] Favor column ids over column names in scan tokens ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13562/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java: http://gerrit.cloudera.org:8080/#/c/13562/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java@162 PS1, Line 162: Extra space here. http://gerrit.cloudera.org:8080/#/c/13562/1/src/kudu/client/client.proto File src/kudu/client/client.proto: http://gerrit.cloudera.org:8080/#/c/13562/1/src/kudu/client/client.proto@58 PS1, Line 58: repeated uint32 projected_column_ids = 21; ColumnSchemaPB already has an id field; why can't we just fill it? -- To view, visit http://gerrit.cloudera.org:8080/13562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3f05a4175c7e7bfaec2cbd3586723e6de3823f0 Gerrit-Change-Number: 13562 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2019 22:00:21 +0000 Gerrit-HasComments: Yes
