Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13562 )
Change subject: [java] Favor column ids over column names in scan tokens ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13562/1/src/kudu/client/client.proto File src/kudu/client/client.proto: http://gerrit.cloudera.org:8080/#/c/13562/1/src/kudu/client/client.proto@58 PS1, Line 58: repeated uint32 projected_column_ids = 21; > So the C++ and Java Schema/ColumnSchema code agree on this: Yeah that's probably a better way to do it. Im gonna have to plumb through all the SCHEMA_PB_{WITH|WITHOUT}_IDS stuff everywhere. -- To view, visit http://gerrit.cloudera.org:8080/13562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3f05a4175c7e7bfaec2cbd3586723e6de3823f0 Gerrit-Change-Number: 13562 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Sat, 08 Jun 2019 02:11:20 +0000 Gerrit-HasComments: Yes
