Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13573 )
Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the specified table ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13573/2/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/13573/2/src/kudu/client/client-internal.h@148 PS2, Line 148: // Retrieve table information about the table identified by 'table_id_or_name'. : // 'table_id_or_name' should contain a table id or name as 'identifier_type' : // is ID or NAME, respectively. Can you update this? http://gerrit.cloudera.org:8080/#/c/13573/2/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: http://gerrit.cloudera.org:8080/#/c/13573/2/src/kudu/integration-tests/tablet_history_gc-itest.cc@133 PS2, Line 133: shared_ptr<KuduTable> table; : ASSERT_OK(client_->OpenTable(TestWorkload::kDefaultTableName, &table)); : KuduScanner scanner(table.get()); : ASSERT_OK(scanner.SetReadMode(KuduScanner::READ_AT_SNAPSHOT)); : Status s = scanner.Open(); Since this is repeated below, could you encapsulate it into a lambda that returns a Status? -- To view, visit http://gerrit.cloudera.org:8080/13573 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaac649154ae3c60785736ab246074c4dcb5b8987 Gerrit-Change-Number: 13573 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jun 2019 16:39:24 +0000 Gerrit-HasComments: Yes
