Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13573 )

Change subject: KUDU-2514 Part 2: Supports setting history_max_age_sec for the 
specified table
......................................................................


Patch Set 5: Verified+1 Code-Review+2

(1 comment)

Test failure was unrelated.

http://gerrit.cloudera.org:8080/#/c/13573/4/src/kudu/client/client-internal.h
File src/kudu/client/client-internal.h:

http://gerrit.cloudera.org:8080/#/c/13573/4/src/kudu/client/client-internal.h@148
PS4, Line 148:   // Get the table information identified by 'table_identifier'.
> > Ah, you don't need to use the Doxygen style for internal functions.
Yeah looks nice!



--
To view, visit http://gerrit.cloudera.org:8080/13573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaac649154ae3c60785736ab246074c4dcb5b8987
Gerrit-Change-Number: 13573
Gerrit-PatchSet: 5
Gerrit-Owner: Yao Xu <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Yao Xu <[email protected]>
Gerrit-Comment-Date: Wed, 12 Jun 2019 03:43:44 +0000
Gerrit-HasComments: Yes

Reply via email to