Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet statistics ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/13426/9/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/13426/9/src/kudu/tserver/ts_tablet_manager.cc@1570 PS9, Line 1570: tablet->CountLiveRows(&count); > Hrm, I think skipping the unsupported tablets will be better. Warning is no So it's clear to future readers that this was intentional, let's wrap this in ignore_result() and add a comment along the lines of "In case the tablet doesn't support counting live rows, ignore the result." or something similar. http://gerrit.cloudera.org:8080/#/c/13426/9/src/kudu/tserver/ts_tablet_manager.cc@1571 PS9, Line 1571: pb.set_row_count(count); : pb.set_disk_size(tablet->OnDiskSize()); > I hope to hear more info :) Yeah, I was thinking of this feature as more of a "aggregated stats for a table" patch rather than "aggregated metrics". I haven't thought of any additional interesting aggregated metrics, but I can certainly think of interesting stats. So I'm leaning towards keeping this as is. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 9 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 06:12:01 +0000 Gerrit-HasComments: Yes
