Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet statistics ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/13426/9/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/13426/9/src/kudu/master/master_path_handlers.cc@394 PS9, Line 394: if (role == RaftPeerPB::LEADER) { > 1. Yes, I still think that's valuable, it's just that it'll also be valuabl I agree with your sentiment Adar, but it seems to me that this should be OK to do in the web UI as an initial patch, and then we should centralize the aggregation and could improve the stability when further integrating it in a follow-up patch that adds metrics or query engine support. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 9 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2019 17:00:14 +0000 Gerrit-HasComments: Yes
