Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13599 )
Change subject: [sentry] Add ListPrivilegesByAuthoriablesAndUser sentry client API ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client-test.cc@185 PS3, Line 185: authorizabkes authorizables http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client-test.cc@200 PS3, Line 200: ASSERT_OK(sentry_client_->ListPrivilegesByAuthoriablesAndUser(request, &response)); Does it make sense to check what exactly was returned? http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client.cc File src/kudu/sentry/sentry_client.cc: http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client.cc@182 PS3, Line 182: user authorizables and user http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client.cc@184 PS3, Line 184: authoriables nit: authorizables -- To view, visit http://gerrit.cloudera.org:8080/13599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3232ad41cc827f593732072a6670c138d524bfb Gerrit-Change-Number: 13599 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 13 Jun 2019 06:14:06 +0000 Gerrit-HasComments: Yes
