Hello Alexey Serbin, Adar Dembo, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13608
to review the following change.
Change subject: KUDU-2850: fix thrift comparison
......................................................................
KUDU-2850: fix thrift comparison
In the operator< implementations, we previously wouldn't return early
when determining that a field in the LHS was greater than that in the
RHS, when we should have returned false.
I added a test for each operator I updated that would fail without this
patch.
Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
---
M src/kudu/sentry/thrift_operators-test.cc
M src/kudu/sentry/thrift_operators.cc
2 files changed, 82 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/13608/1
--
To view, visit http://gerrit.cloudera.org:8080/13608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
