Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties ...................................................................... Patch Set 2: (1 comment) > (1 comment) > > Thanks for this change! Sorry for the late review. > > Could you upload this to your github and post a link to the page so > it can be rendered, e.g. > https://github.com/apache/kudu/blob/master/docs/configuration.adoc Wow, cool. https://github.com/oclarms/kudu/blob/KUDU-2514/docs/configuration.adoc http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc File docs/configuration.adoc: http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@150 PS1, Line 150: U > For 1.10+, this should be 60 * 60 * 24 * 7 (7 days) I think this may be a bit inaccurate. For example, if I change the tablet_history_max_age_sec of tablet server by gflags, then the default value here is wrong. Maybe we should write like this: Use tablet_history_max_age_sec of Tablet Server -- To view, visit http://gerrit.cloudera.org:8080/13704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b Gerrit-Change-Number: 13704 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Comment-Date: Sat, 22 Jun 2019 03:51:59 +0000 Gerrit-HasComments: Yes
