Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13704 )
Change subject: [docs] Add docs for extra configuration properties ...................................................................... Patch Set 2: (3 comments) > Patch Set 2: > > (1 comment) > > > (1 comment) > > > > Thanks for this change! Sorry for the late review. > > > > Could you upload this to your github and post a link to the page so > > it can be rendered, e.g. > https://github.com/apache/kudu/blob/master/docs/configuration.adoc > > Wow, cool. > https://github.com/oclarms/kudu/blob/KUDU-2514/docs/configuration.adoc Thanks! :D http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc File docs/configuration.adoc: http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@143 PS1, Line 143: To configure the behavior of each Kudu table, you can set or alter these configurations : by API or CLI. nit: maybe add a little context about table-level configurations. Something like. Kudu allows certain configurations to be set per table. To configure the behavior of a Kudu table, you can set these configurations at table creation, or alter them via the Kudu API or Kudu command line tool. http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@146 PS1, Line 146: Configuration nit: maybe "Configurable Properties"? http://gerrit.cloudera.org:8080/#/c/13704/1/docs/configuration.adoc@150 PS1, Line 150: U > > For 1.10+, this should be 60 * 60 * 24 * 7 (7 days) I see. I agree isn't the most future proof thing ever. How about let's remove the "Default" column here entirely, since I think most defaults will be to use the tserver default. -- To view, visit http://gerrit.cloudera.org:8080/13704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fe61efeafa9bd9d4cf62a378b6c4c7039bbcf6b Gerrit-Change-Number: 13704 Gerrit-PatchSet: 2 Gerrit-Owner: Yao Xu <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2019 17:40:26 +0000 Gerrit-HasComments: Yes
